feat: presign url using blob storage #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bestmike007 <i@bestmike007.com>
Signed-off-by: bestmike007 <i@bestmike007.com>
jiezhang
reviewed
Jan 22, 2024
internal/storage/blobstorage/gcs/blob_storage_integration_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Jie Zhang <zhangjie@gmail.com>
Signed-off-by: bestmike007 <i@bestmike007.com>
Signed-off-by: bestmike007 <i@bestmike007.com>
Signed-off-by: bestmike007 <i@bestmike007.com>
Signed-off-by: bestmike007 <i@bestmike007.com>
bestmike007
force-pushed
the
feat/presign-url-in-blob-storage
branch
from
a092a8d to
b3faa94
Compare
Signed-off-by: bestmike007 <i@bestmike007.com>
jiezhang
reviewed
Jan 25, 2024
internal/server/handler.go
Outdated
| @@ -715,7 +715,8 @@ func (s *Server) newBlockFile(block *api.BlockMetadata) (*api.BlockFile, error) | |||
| compression := storage_utils.GetCompressionType(key) | |||
| fileUrl, err := s.blobStorage.PreSign(context.Background(), key) | |||
| if err != nil { | |||
| return nil, err | |||
| s.logger.Error("block file s3 presign error", zap.String("key", key), zap.Error(err)) | |||
There was a problem hiding this comment.
there is a logging interceptor taking care of the logs
internal/server/handler.go
Outdated
| @@ -715,7 +715,8 @@ func (s *Server) newBlockFile(block *api.BlockMetadata) (*api.BlockFile, error) | |||
| compression := storage_utils.GetCompressionType(key) | |||
| fileUrl, err := s.blobStorage.PreSign(context.Background(), key) | |||
| if err != nil { | |||
| return nil, err | |||
| s.logger.Error("block file s3 presign error", zap.String("key", key), zap.Error(err)) | |||
| return nil, status.Errorf(codes.Internal, "internal block file url generation error: %+v", err) | |||
There was a problem hiding this comment.
all errors are by default mapped to internal by the error interceptor. no need to repeat it here.
jiezhang
reviewed
Jan 25, 2024
| @@ -25,6 +25,9 @@ aws: | |||
| region: us-east-1 | |||
| storage: | |||
| data_compression: GZIP | |||
| gcp: | |||
There was a problem hiding this comment.
You may want to change GcpConfig to a pointer so it becomes optional. Then I guess we don't need to add this section to the default template?
There was a problem hiding this comment.
It's already a pointer, so optional. However, since we marked the presigned_url_expiration required, we need a default value for it because gcp project is always required for firestore.
Signed-off-by: bestmike007 <i@bestmike007.com>
jiezhang
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
PreSigned url needs to be moved into specific blob storage type.
How did you test the change?
GitHub Actions